-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 05 November 2002 23:02, Till Krech wrote:
> On Tuesday 05 November 2002 22:19, David Faure wrote:
> > On Tuesday 05 November 2002 21:38, Till Krech wrote:
> > > First, a small addition to your patch. At least when called from the
> > > plugin, the javascript url is urlencoded because once on the way a KURL
> > > is made from a QString. Therefore, my version looks like this:
> > >
> > > +  if ( urlStr.find( QString::fromLatin1( "javascript:" ), 0, false ) ==
> > > 0 ) { +      QString script = KURL::decode_string( urlStr.right(
> > > urlStr.length() - 11 ) );
> > > +      executeScript( script );
> > > +      return;
> >
> > This looks consistent with slotRedirect...... But it also looks
> > unnecessarily obfuscated: wouldn't url.path() do the job? It should both
> > remove the protocol and decode the string.
> hmm...
> try this:
> javascript:document.images.length/2
> isn't the path "/2" ? and host "document.images.length"
This one works (I guess because there's no '/' before the 'host').

> and another:
> javascript:confirm("Really leave this page? You will miss this & that.")
But you're right about that one.
Ok for decode_string then.

> > Yes, when you click the link, it _replaces_ the current page with the html
> > returned by the javascript code. I guess it's the equivalent of
> > document.write(result_of_javascript_eval), which does the same thing.
> > We don't handle this case yet - that's the case that needs code like
> > the one in requestFrame().
> Ok. This seems to be something for KDE 3.2
> Concerning the small patch. It fixes at least the bug on 
> http://www.cocacola.com where you currently cannot click the links.
> Would you like to commit ?
Ok, committed, with the decode_string added.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
Get the latest KOffice - http://download.kde.org/stable/koffice-1.2/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9yZW272KcVAmwbhARAnDDAJoDu6z6o3U/N9+Z6AePNtdK7HU0ogCfdrBy
LZi+InPrEW3MGTrDjDqUeUI=
=pbIt
-----END PGP SIGNATURE-----