[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: [PATCH] Speed up iconView's setIcons 2x...
From:       Maks Orlovich <mo002j () mail ! rochester ! edu>
Date:       2002-08-17 19:48:06
[Download RAW message or body]

Koos Vriezen wrote:

> On Wed, 14 Aug 2002, Maks Orlovich wrote:
> 
>> Lars Knoll wrote:
>>
>> > A few comments....
>> >
>> > The repaint in the original patch shopuld probably be an update() call.
>> > This posts the event (instead of triggering the paint event
>> > synchronously), so several calls can be merged by Qt. It usually
>> > reduces flicker quite a bit and should also make it faster.
>>
>> Thanks for the suggestion... Koos, could you try with this change and see
>> whether it helps? If not, could you please describe more of your testing
>> setup.. I timed (clock counters) what you described, and it seems
>> signficantly faster with the patch... Also, Lars' suggestion gives me an
>> idea of how to reduce flicker: in KonqKfmIconView::newIconSize( int size
>> ) (konqueror/iconview/knq_iconview.cc), change:
>> m_pIconView->arrangeItemsInGrid( ); to:
> 
> Yes, it seems faster and no blocking. Now I see one or two repaints when
> entering a dir.

I guess if it does look faster I'll go ahead an commit Monday evening if no 
one else has any comments... Thanks a lot for the testing and the 
comments..

[prev in list] [next in list] [prev in thread] [next in thread]