-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 19 July 2002 05:25, Doug Hanley wrote:
> On Monday 15 July 2002 01:10 pm, David Faure wrote:
> > The point is that:
> > * openURL might or might not know the mimetype. If it does, it calls
> > openView. If it doesn't, it creates a KonqRun which will call openView
> > later too. * openView *ALWAYS* knows the mimetype. It's been found out
> > before, see above ;)
> 
> > Better yet: let openURL find the mimetype first if necessary, and then,
> > in openView, create the tab around the part.
> > I guess you simply need a flag that tells openView to create a tab
> > instead of a normal view.
> >
> > All the logic for the mimetype determination is in place and works fine,
> > use it, don't work around it. Thanks ;)
> 
> Heres a new patch that takes all that into account, seems to work well.  
> Should I commit?

Looks good to me.

> (sorry that this patch is kind of large)

A much smaller solution (less code changes) would have been to add the
newTab bool to the KonqOpenURLRequest struct. That's exactly what it's there
for: to easily add new "do this when opening this URL" data, without having to
change so much API. Sorry that I didn't think of mentionning this earlier.
I understand if you don't want to rewrite this patch yet another time
(but in all theory it would be cleaner to have it in KonqOpenURLRequest ;-)
Do whichever way you prefer.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
On holidays from 20/07 to 24/07
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9OEI+72KcVAmwbhARAm5xAJ9cW3SkerOWXJJXfazYoAqPGzrUpACeOgo6
kN+SJyNMiG3dx9imaOkZe1E=
=5ZZf
-----END PGP SIGNATURE-----