[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: going back in khtml_part.cpp
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-07-19 16:42:57
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Friday 19 July 2002 02:14, Daniel Naber wrote:
> Okay, it took some time but now here's a patch that makes "go back on right 
> click" work in framesets. Can I commit?

Looks good, except for the 3 lines below:

>    if (reset || config->hasGroup("HTML Settings"))
>    {
> +    config->setGroup( "MainView Settings" );

This code should be moved under a hasGroup("MainView Settings") test,
having it under hasGroup("HTML Settings") sounds wrong.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
On holidays from 20/07 to 24/07
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9OEGR72KcVAmwbhARAgnnAJ9sIaLiHn8BGtLmVtxuIBOcPE9bdgCeK+Gk
rF4clLxKnW1Dp4l3Mx//mUM=
=2hXg
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]