On Wed, 17 Jul 2002, Till Krech wrote:
> > On Tuesday 16 July 2002 10:10, Koos Vriezen wrote:
> > >
> > > There is a problem with giving the focus to an embedded window with a
> > > mouse click when a form element has the current focus.
> > >
> > > I've attached a patch which fixes it. It does:
> > > - do a XGrabButton on a embedded window when the mouse enters it and it
> > >   doesn't have the focus
> > > - do a XUngrabButton when the mouse leaves the embedded window or when
> > >   it receives the focus
> > > - put the focus to the embedded window when its clicked
> > >
> > > This is similar behaviour as KWin does on its clients (damn, should have
> > > looked at that earlier)
> >
> I can't test the applet though on
> http://chat.tapuz.co.il/newchat/main.asp?regUser=no&shower=1&room=30%20%C3%B4%C3%AC%C3%A5%C3%B1%20%C3%A0%C3%A9%C3%AB%C3%A5%C3%BA%C3%A9&nick=fasdfasd
>
> It gets now a null pointer exception - but also without the patch . But this
> may be related to the URL change. Was a bit shorter last time, I checked.

Works for me (I bookmarked it)

> A little testcase Applet with a textfield works fine. What else do we have to
> test ? QXEmbed is, apart from nspluginviewer,  also used for Kicker applets
> and Kasbar.

Seems not to break it. Hmm
    bool ExternalAppletContainer::process
        .....
        else if(fun == "requestFocus()")
        {
            activateWindow();
            return(true);
        }
looks like it's using DCOP for getting the focus. We have redundancy
here.

> Koos, thanks a lot for finding this,

Thanks,

Koos