This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. ---1463811574-790435161-1026828601=:1487 Content-Type: TEXT/PLAIN; charset=US-ASCII Hi, There is a problem with giving the focus to an embedded window with a mouse click when a form element has the current focus. I've attached a patch which fixes it. It does: - do a XGrabButton on a embedded window when the mouse enters it and it doesn't have the focus - do a XUngrabButton when the mouse leaves the embedded window or when it receives the focus - put the focus to the embedded window when its clicked This is similar behaviour as KWin does on its clients (damn, should have looked at that earlier) Regards, Koos ---1463811574-790435161-1026828601=:1487 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="qxembed-focus.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="qxembed-focus.diff" SW5kZXg6IGtkZXVpL3F4ZW1iZWQuY3BwDQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09DQpSQ1MgZmlsZTogL2hvbWUva2RlL2tkZWxpYnMva2RldWkvcXhlbWJl ZC5jcHAsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjI5DQpkaWZmIC11IC0z IC1wIC1yMS4yOSBxeGVtYmVkLmNwcA0KLS0tIGtkZXVpL3F4ZW1iZWQuY3Bw CTIwMDIvMDcvMTUgMjI6MDQ6MTgJMS4yOQ0KKysrIGtkZXVpL3F4ZW1iZWQu Y3BwCTIwMDIvMDcvMTYgMTM6MjY6MjINCkBAIC0yMCw2ICsyMCw3IEBADQog KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKiovDQogDQogI2luY2x1 ZGUgPHFhcHBsaWNhdGlvbi5oPg0KKyNpbmNsdWRlIDxxbWV0YW9iamVjdC5o Pg0KICNpbmNsdWRlIDxxcHRybGlzdC5oPg0KICNpbmNsdWRlIDxxcHRyZGlj dC5oPg0KICNpbmNsdWRlIDxxZ3VhcmRlZHB0ci5oPg0KQEAgLTIwNSw2ICsy MDYsMjAgQEAgc3RhdGljIGludCBxeGVtYmVkX3gxMV9ldmVudF9maWx0ZXIo IFhFdg0KICAgICAvL2tkRGVidWcoKSA8PCAicXhlbWJlZF94MTFfZXZlbnRf ZmlsdGVyICIgPDwgS1hFdmVudFV0aWw6OmdldFgxMUV2ZW50SW5mbyhlKSA8 PCBlbmRsOw0KIA0KICAgICBzd2l0Y2ggKCBlLT50eXBlICkgew0KKyAgICBj YXNlIExlYXZlTm90aWZ5OiB7DQorICAgICAgICBRV2lkZ2V0KiB3ID0gUVdp ZGdldDo6ZmluZCggZS0+eGtleS53aW5kb3cgKTsNCisgICAgICAgIGlmICh3 ICYmIHctPm1ldGFPYmplY3QoKS0+aW5oZXJpdHMoIlFYRW1iZWQiKSkNCisg ICAgICAgICAgICBYVW5ncmFiQnV0dG9uKCBxdF94ZGlzcGxheSgpLCBBbnlC dXR0b24sIEFueU1vZGlmaWVyLCBlLT54YW55LndpbmRvdyApOw0KKyAgICAg ICAgYnJlYWs7DQorICAgIH0NCisgICAgY2FzZSBFbnRlck5vdGlmeTogew0K KyAgICAgICAgUVdpZGdldCogdyA9IFFXaWRnZXQ6OmZpbmQoIGUtPnhrZXku d2luZG93ICk7DQorICAgICAgICBpZiAodyAmJiB3LT5tZXRhT2JqZWN0KCkt PmluaGVyaXRzKCJRWEVtYmVkIikgJiYgIXctPmhhc0ZvY3VzKCkpDQorICAg ICAgICAgICAgWEdyYWJCdXR0b24ocXRfeGRpc3BsYXkoKSwgQW55QnV0dG9u LCBBbnlNb2RpZmllciwgZS0+eGFueS53aW5kb3csDQorICAgICAgICAgICAg ICAgICAgICBGQUxTRSwgQnV0dG9uUHJlc3NNYXNrLCBHcmFiTW9kZVN5bmMs IEdyYWJNb2RlQXN5bmMsDQorICAgICAgICAgICAgICAgICAgICBOb25lLCBO b25lICk7DQorICAgICAgICBicmVhazsNCisgICAgfQ0KICAgICBjYXNlIFhL ZXlQcmVzczogew0KICAgICAgICAgaW50IGtjID0gWEtleWNvZGVUb0tleXN5 bShxdF94ZGlzcGxheSgpLCBlLT54a2V5LmtleWNvZGUsIDApOw0KICAgICAg ICAgaWYgKCBrYyA9PSBYS19UYWIgfHwga2MgPT0gWEtfSVNPX0xlZnRfVGFi ICkgew0KQEAgLTU3Miw2ICs1ODcsNyBAQCB2b2lkIFFYRW1iZWQ6OmtleVJl bGVhc2VFdmVudCggUUtleUV2ZW50DQogdm9pZCBRWEVtYmVkOjpmb2N1c0lu RXZlbnQoIFFGb2N1c0V2ZW50ICogZSApew0KICAgICBpZiAoIXdpbmRvdykN CiAgICAgICAgIHJldHVybjsNCisgICAgWFVuZ3JhYkJ1dHRvbiggcXRfeGRp c3BsYXkoKSwgQW55QnV0dG9uLCBBbnlNb2RpZmllciwgd2luZG93ICk7DQog ICAgIGludCBkZXRhaWwgPSBYRU1CRURfRk9DVVNfQ1VSUkVOVDsNCiAgICAg aWYgKCBlLT5yZWFzb24oKSA9PSBRRm9jdXNFdmVudDo6VGFiICkNCiAgICAg ICAgIGRldGFpbCA9IHRhYkZvcndhcmQ/WEVNQkVEX0ZPQ1VTX0ZJUlNUOlhF TUJFRF9GT0NVU19MQVNUOw0KQEAgLTcyOCw2ICs3NDQsMTUgQEAgYm9vbCBR WEVtYmVkOjp4MTFFdmVudCggWEV2ZW50KiBlKQ0KICAgICAgICAgICAgIHdp bmRvdyA9IGUtPnhyZXBhcmVudC53aW5kb3c7DQogICAgICAgICAgICAgZW1i ZWQoIHdpbmRvdyApOw0KICAgICAgICAgfQ0KKyAgICAgICAgYnJlYWs7DQor ICAgIGNhc2UgQnV0dG9uUHJlc3M6DQorICAgICAgICBRRm9jdXNFdmVudDo6 c2V0UmVhc29uKCBRRm9jdXNFdmVudDo6TW91c2UgKTsNCisgICAgICAgIHNl dEZvY3VzKCk7DQorICAgICAgICBRRm9jdXNFdmVudDo6cmVzZXRSZWFzb24o KTsNCisgICAgICAgIFhBbGxvd0V2ZW50cyhxdF94ZGlzcGxheSgpLCBSZXBs YXlQb2ludGVyLCBDdXJyZW50VGltZSk7DQorICAgICAgICByZXR1cm4gVFJV RTsNCisgICAgY2FzZSBCdXR0b25SZWxlYXNlOg0KKyAgICAgICAgWEFsbG93 RXZlbnRzKHF0X3hkaXNwbGF5KCksIFN5bmNQb2ludGVyLCBDdXJyZW50VGlt ZSk7DQogICAgICAgICBicmVhazsNCiAgICAgY2FzZSBNYXBSZXF1ZXN0Og0K ICAgICAgICAgaWYgKCB3aW5kb3cgJiYgZS0+eG1hcHJlcXVlc3Qud2luZG93 ID09IHdpbmRvdyApDQo= ---1463811574-790435161-1026828601=:1487--