[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: smbmount konqy plugin
From:       Malte Starostik <malte () kde ! org>
Date:       2002-06-24 19:05:00
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Monday 24 June 2002 00:34 schrieb aleXXX:
> Hi,
>
> finally I got my smbmount plugin working.
> If the current url of konqy is "inside" a smb share, there is a smbmount
> entry in the tools menu if the share is not mounted, a smbumount entry if
> it is already mounted.
> The (u)mounting is done via the special() function of the smbro ioslave,
> which calls smb(u)mount.
>
> This is nice e.g. for browsing your network and then playing mp3's or
> movies via xmms or mplayer.
Nice!
On a side note, there's a small problem with konq and smbmounted dirs (maybe 
also applies to mounted netware shares?): The very clever assumption that a 
dir has subdirs if has a higher link count than 2 doesn't hold true for 
those: the link count is always one.
In http://malte.homeip.net/konq-smbshare.png you can see that the subdirs of 
"Dokumente und Einstellungen" are not expandable in the side bar as they 
should (The selected "All Users" directory does have subdirs). "Dokumente und 
Einstellungen" is only expandable and expanded because I navigated to there 
using the icon view.
Windows Explorer marks all remote directories (network neighbourhood and 
mapped drives) expandable by default and only checks if they really are when 
the user tries to expand them. We do the same for remote URLs already, maybe 
we should also do it with dirs with st_nlink == 1?
The attached patch makes smb mounted dirs browsable in the sidebar, does it 
break anything? If not, I'd commit and do something like that in 
KFileTreeBranch as well.

- -- 
Malte Starostik
PGP: 1024D/D2F3C787 [C138 2121 FAF3 410A 1C2A  27CD 5431 7745 D2F3 C787]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iD8DBQE9F21fVDF3RdLzx4cRAh1yAKCg1ELEKUBzIefwnBRPbEc2GlzeIgCeOWn5
B6+uIiTGSsHuioBmfmouCD4=
=y2J6
-----END PGP SIGNATURE-----

["dirtree.diff" (text/x-diff)]

Index: dirtree_item.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/dirtree_module/dirtree_item.cpp,v
retrieving revision 1.12
diff -u -3 -d -p -r1.12 dirtree_item.cpp
--- dirtree_item.cpp	2002/02/21 16:28:10	1.12
+++ dirtree_item.cpp	2002/06/24 19:04:34
@@ -67,7 +67,7 @@ void KonqSidebarDirTreeItem::init()
             if ( ::stat( path.data(), &buff ) != -1 )
             {
                 //kdDebug() << "KonqSidebarDirTreeItem::init " << path << " : " << \
                buff.st_nlink << endl;
-                if ( buff.st_nlink <= 2 )
+                if ( buff.st_nlink == 2 )
                     setExpandable( false );
             }
         }



[prev in list] [next in list] [prev in thread] [next in thread]