[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Kget->kdenetwork
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-06-24 9:55:55
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Monday 24 June 2002 11:05, pch@valleeurope.net wrote:
> Hi David,
> I think that kget is ready to leave kdenonbeta for
> kdenetwork can you move it?

Just had a quick look at the code, to estimate the overall quality ;)

- - Why does Errors.h contain a full copy of the enums from kio/global.h ?
- - For the Min macro in common.h, you can use kMin.
- - The KActions are created with a QIconSet, sometimes coming from an XPM.
Ouch. This doesn't work well (e.g. when plugging the same action in a toolbar
and in a menubar). Please make them all PNGs, install into the recommended dir,
and simply use "iconname" (no extension!) in the KAction constructor 
(no locate, no QIconSet etc.). See other apps or the developer FAQ
- - I see some static QStrings ! static objects are quite evil. Well and in this
case (setWhatsThis) not useful at all IMHO.
- - The edit toolbar thingie doesn't obey the apply button (see KEditToolbar docu)

The rest looks quite good ;)
OK for moving it - well, only kdenonbeta/kget/kget, we don't need any of the toplevel stuff
for compilation. You might need a few files from there though (AUTHORS, README). 
Hmm, I see two choices:
* kdenetwork/kget with all in there (standard setup)
* kdenetwork/kget with the sources under src/  (many people find $app/$app a bit stupid ;)

But in any case configure.in.in needs to go, all the Makefile.* stuff of the toplevel too, etc.
Please tell me what you prefer.

- -- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/
Contributing to: http://www.konqueror.org/, http://www.koffice.org/
KOffice-1.2-beta2 is coming very shortly...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9Fuys72KcVAmwbhARAleOAJ9gPKoyfrozGvUmi5SJacsu28z18wCgolJZ
sIV+Bbh1hMYBttt33VWtBhE=
=pSUw
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]