[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Text Selection Speed
From:       Dirk Mueller <mueller () kde ! org>
Date:       2002-06-23 18:48:57
[Download RAW message or body]

On Sam, 22 Jun 2002, Koos Vriezen wrote:

> Attached a patch that contains my two previous patches, only repaint the
> selected object and the re-scheduling changes, with some improvements.

- what you hacked together with QValueList<QRect> is handled MUCH more 
  efficiently in QRegion. Please use that instead.

- DocumentImpl is not part of the public interface. there is no need
  to add a Private class to it. 

> It also adds 'cachedInnerNode' to DocumentImpl.

which is broken. 

> 'DocumentImpl::prepareMouseEvent' first looks if the mouse is still in
> this object, before rescanning the rendering tree. This saves a lot of CPU
> cycles when moving the mouse above khtml part.

And doesn't work. while the mouse might be still inside the previous 
"innernode", there might be a new "more inner" innernode now. Your caching 
breaks for this case. 

Believe me, if it had been that simple it would be already implemented ;-)

> There is no reference counting in Render*, so I'm not 100% sure this
> cached node is always valid.

Yes, additional headache. 


Dirk
[prev in list] [next in list] [prev in thread] [next in thread]