[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    [PATCH] Fixed infinite folder animation in sidebar
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2002-03-06 1:42:49
[Download RAW message or body]

Hello,

see subject.
If you click folder of main window, folder animation(yellow mini gear) in
sidebar does not stop. The attached patch fixed this bug.

If this patch has not a problem, please commit.
-- 
Toshitaka Fujioka
http://www.kde.org                The K Desktop Environment Project
                                                    fujioka@kde.org
http://www.kde.gr.jp               Japan KDE User's Group
                                                    toshitaka@kde.gr.jp

-- A journey of a thousand miles must begin with a single step.  Lao-zi --  
["kdebase-konqueror-fixInfiniteFolderAnimation-20020306.diff" (text/x-diff)]

? kdebase-konqueror-fixInfiniteFolderAnimation-20020306.diff
Index: dirtree_module.cpp
===================================================================
RCS file: /home/kde/kdebase/konqueror/sidebar/trees/dirtree_module/dirtree_module.cpp,v
retrieving revision 1.15
diff -u -3 -d -p -r1.15 dirtree_module.cpp
--- dirtree_module.cpp	2002/02/27 22:21:37	1.15
+++ dirtree_module.cpp	2002/03/06 01:37:08
@@ -166,8 +166,6 @@ void KonqSidebarDirTreeModule::openSubFo
         m_pProps = new KonqPropsView(tree()->part()->parentInstance(), s_defaultViewProps );
     }
 
-    listDirectory( item );
-
     if ( !item->isTopLevelItem() &&
          static_cast<KonqSidebarDirTreeItem *>(item)->hasStandardIcon() )
     {
@@ -177,6 +175,8 @@ void KonqSidebarDirTreeModule::openSubFo
     }
     else
         m_pTree->startAnimation( item );
+
+    listDirectory( item );
 }
 
 void KonqSidebarDirTreeModule::listDirectory( KonqSidebarTreeItem *item )


[prev in list] [next in list] [prev in thread] [next in thread]