This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --655616-24272995-1014539580=:1326 Content-Type: TEXT/PLAIN; charset=US-ASCII The attach patch removes the code that was causing the odd scrolling behaviour. Now when you tab it just goes to the next or previous link based on the tab index rather than what is present on the screen, and scrolls appropriately. On Sun, 17 Feb 2002, Tobias Anton wrote: > Hi Peter ! > > Go to www.heise.de with testkhtml and try tabbing forward and backward (mixed). > You'll find that when you once reached the last link, tabbing forward won't cause KHTML to jump to the beginning of the HTML page as it's supposed to. > > Some other bugs on which I spent quite some time before reappeared, but they're complicated to describe, so only one example here: > > Let's say there's a long page that contains two links: one with a high tabindex on the > very top of the page, and one with a low tabindex on the bottom. > Now the view should begin on top of the document, scroll down to the link with the low tabindex, then should scroll up again to the anchor with the high tabindex and finally it should scroll to the bottom of the page before releasing focus to the parent part or whatever. > > Note that on such a page, a direction change (suddenly pressing shift-tab after having tabbed forward before to approach a non-visible node) > does behave like tabbing forward in your new implementation. This worked before. > > I'm a bit confused about the fundamental rewrite of the tabbing code that worked before; i.e. did it already respect the tabindex attribute, so there has been no improvement to that feature. > > I also didn't find any correspondence about that topic on kfm-devel, maybe you can bring me up-to-date? > > Cheers, > Tobias > -- Peter Kelly pmk@post.com --655616-24272995-1014539580=:1326 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="tab.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="tab.diff" PyBhDQpJbmRleDoga2h0bWx2aWV3LmNwcA0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQ0KUkNTIGZpbGU6IC9ob21lL2tkZS9rZGVsaWJzL2todG1sL2todG1s dmlldy5jcHAsdg0KcmV0cmlldmluZyByZXZpc2lvbiAxLjQ1MA0KZGlmZiAt dSAtcCAtcjEuNDUwIGtodG1sdmlldy5jcHANCi0tLSBraHRtbHZpZXcuY3Bw CTIwMDIvMDIvMTQgMTY6MTU6MzIJMS40NTANCisrKyBraHRtbHZpZXcuY3Bw CTIwMDIvMDIvMjQgMDg6MTE6MzUNCkBAIC04ODYsMzEgKzg4Niw2IEBAIHZv aWQgS0hUTUxWaWV3Ojpmb2N1c05leHRQcmV2Tm9kZShib29sIG4NCiAgICAg ZWxzZQ0KICAgICAgICAgbmV3Rm9jdXNOb2RlID0gZG9jLT5wcmV2aW91c0Zv Y3VzTm9kZShvbGRGb2N1c05vZGUpOw0KIA0KLSAgICAvLyBJZiB0aGVyZSB3 YXMgcHJldmlvdXNseSBubyBmb2N1cyBub2RlIGFuZCB0aGUgdXNlciBoYXMg c2Nyb2xsZWQgdGhlIGRvY3VtZW50LCB0aGVuIGluc3RlYWQgb2YgcGlja2lu ZyB0aGUgZmlyc3QNCi0gICAgLy8gZm9jdXNhYmxlIG5vZGUgaW4gdGhlIGRv Y3VtZW50LCB1c2UgdGhlIGZpcnN0IG9uZSB0aGF0IGxpZXMgd2l0aGluIHRo ZSB2aXNpYmxlIGFyZWEgKGlmIHBvc3NpYmxlKS4NCi0gICAgaWYgKCFvbGRG b2N1c05vZGUgJiYgbmV3Rm9jdXNOb2RlKSB7DQotICAgICAgICBib29sIHZp c2libGUgPSBmYWxzZTsNCi0gICAgICAgIE5vZGVJbXBsICp0b0ZvY3VzID0g bmV3Rm9jdXNOb2RlOw0KLSAgICAgICAgd2hpbGUgKCF2aXNpYmxlICYmIHRv Rm9jdXMpIHsNCi0gICAgICAgICAgICBRUmVjdCBmb2N1c05vZGVSZWN0ID0g dG9Gb2N1cy0+Z2V0UmVjdCgpOw0KLSAgICAgICAgICAgIGlmICgoZm9jdXNO b2RlUmVjdC5sZWZ0KCkgPiBjb250ZW50c1goKSkgJiYgKGZvY3VzTm9kZVJl Y3QucmlnaHQoKSA8IGNvbnRlbnRzWCgpICsgdmlzaWJsZVdpZHRoKCkpICYm DQotICAgICAgICAgICAgICAgIChmb2N1c05vZGVSZWN0LnRvcCgpID4gY29u dGVudHNZKCkpICYmIChmb2N1c05vZGVSZWN0LmJvdHRvbSgpIDwgY29udGVu dHNZKCkgKyB2aXNpYmxlSGVpZ2h0KCkpKSB7DQotICAgICAgICAgICAgICAg IC8vIHRvRm9jdXMgaXMgdmlzaWJsZSBpbiB0aGUgY29udGVudHMgYXJlYQ0K LSAgICAgICAgICAgICAgICB2aXNpYmxlID0gdHJ1ZTsNCi0gICAgICAgICAg ICB9DQotICAgICAgICAgICAgZWxzZSB7DQotICAgICAgICAgICAgICAgIC8v IHRvRm9jdXMgaXMgX25vdF8gdmlzaWJsZSBpbiB0aGUgY29udGVudHMgYXJl YSwgcGljayB0aGUgbmV4dCBub2RlDQotICAgICAgICAgICAgICAgIGlmIChu ZXh0KQ0KLSAgICAgICAgICAgICAgICAgICAgdG9Gb2N1cyA9IGRvYy0+bmV4 dEZvY3VzTm9kZSh0b0ZvY3VzKTsNCi0gICAgICAgICAgICAgICAgZWxzZQ0K LSAgICAgICAgICAgICAgICAgICAgdG9Gb2N1cyA9IGRvYy0+cHJldmlvdXNG b2N1c05vZGUodG9Gb2N1cyk7DQotICAgICAgICAgICAgfQ0KLSAgICAgICAg fQ0KLQ0KLSAgICAgICAgaWYgKHRvRm9jdXMpDQotICAgICAgICAgICAgbmV3 Rm9jdXNOb2RlID0gdG9Gb2N1czsNCi0gICAgfQ0KLQ0KICAgICAvLyBTZXQg Zm9jdXMgbm9kZSBvbiB0aGUgZG9jdW1lbnQNCiAgICAgbV9wYXJ0LT54bWxE b2NJbXBsKCktPnNldEZvY3VzTm9kZShuZXdGb2N1c05vZGUpOw0KICAgICBl bWl0IG1fcGFydC0+bm9kZUFjdGl2YXRlZChOb2RlKG5ld0ZvY3VzTm9kZSkp Ow0K --655616-24272995-1014539580=:1326--