[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Moving frame borders with the mouse
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2002-02-09 17:15:17
[Download RAW message or body]

On Sat, 9 Feb 2002, Dirk Mueller wrote:

> On Sam, 09 Feb 2002, Koos Vriezen wrote:
>
> > This one was easy
>
> Looks correct, go ahead.

Well, one possible stack corruption less.

However the current implementation has the following flaw in this case:
 - a manual resize of frames, remembered in m_gridDelta
 - a resize from JS, myframe.rows = "..", m_gridDelta isn't cleared

Possible solutions:
 1. clear m_gridDelta from HTMLFrameSetElementImpl::parseAttribute
 2. change HTMLFrameSetElementImpl::m_rows/cols directly after a resize
and don't use m_gridDelta in RenderFrameSet::positionFrames

Any preferences?

Koos

[prev in list] [next in list] [prev in thread] [next in thread]