From kfm-devel Fri Jan 25 20:21:14 2002 From: Hamish Rodda Date: Fri, 25 Jan 2002 20:21:14 +0000 To: kfm-devel Subject: Re: KIOSlave errors an konqueror's handling of them X-MARC-Message: https://marc.info/?l=kfm-devel&m=101210578517507 >On Friday 25 January 2002 16:37, Hamish Rodda wrote: >> I see... got it. Would you like to review this before it goes in? > >As you want, I'll review it anyway (either pre-commit or post-commit ;) Ok. Here's some bits I'm not sure about... KHTMLPart::openURL I inserted the error check after d->m_redirectionTimer.stop(); - is this = the=20 right place? Once I worked out the real URL, I set m_workingURL and called: emit d->m_extension->setLocationBarURL( d->m_workingURL.prettyURL() ); then I call the error function, and return true from openURL... however konq still displays the error://etc.. on the end :( Anyway, I'll start committing some foundations soon... btw, should the error messages be part of kdelibs? My first attempt at a friendly error message... http://hamish.curlybracket.com:20080/dav/error.html Hamish