[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: Race in frameset.onLoad event
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2002-01-22 16:35:50
[Download RAW message or body]



On Tue, 22 Jan 2002, David Faure wrote:

> On Tuesday 22 January 2002 03:19, Dirk Mueller wrote:
> > On Mon, 21 Jan 2002, David Faure wrote:
> >
> > > Hmm, not sure if we need that, checkCompleted() calls checkEmitLoadEvent()
> > > anyway.
> >
> > Yes, but on the "this" part not the parent one. With the new check we're
> > going to need that passing one level up imho.
>
> But the parent part already gets notified when a child completes, no ?
> (There's a slotChildCompleted slot connected to completed(...) signals)
>
> So when the child completes, it tells the parent already, and
> slotChildCompleted calls checkCompleted, which in turn calls
> checkEmitLoadEvent if all frames have completed. In fact it first
> checks for images/scripts still to be downloaded, so if we want the load event
> to be emitted before that, the call to checkEmitLoadEvent() in khtml_part.cpp
> should be moved up a few lines - before the "Still waiting for
> images/scripts" check.

IMHO load event should be emitted after global/onload JS scripts from
child frames are executed, childs css files loaded and after the childs
are layouted.

Koos

[prev in list] [next in list] [prev in thread] [next in thread]