From kfm-devel  Tue Jan 01 01:21:20 2002
From: Hamish Rodda <meddie () yoyo ! cc ! monash ! edu ! au>
Date: Tue, 01 Jan 2002 01:21:20 +0000
To: kfm-devel
Subject: Re: Preliminary webdav support in kio_http
X-MARC-Message: https://marc.info/?l=kfm-devel&m=100984823807083

On Tuesday 1 January 2002, Waldo Bastian wrote:
>On Monday 31 December 2001 01:46 am, Hamish Rodda wrote:
>> I've posted a more up-to-date version on
>> http://yoyo.cc.monash.edu.au/~meddie/patches/
>
>Ah cool, looks good.
>
>Some remarks:
>* Does it need to have it's own "webdav" protocol? Can't it just be used=
 for
>http in general?

There are a couple of reasons for this. The most important one is that it=
=20
needs to know when to send a request for a directory listing (PROPFIND /d=
ir/)=20
as compared to a request for the default document of a directory (GET /di=
r/).=20
In fact, having the listing capabilities causes kio to behave very=20
differently (calling listdir instead of stat, etc). Plus, I don't know if=
 we=20
want the http protocol to think it is capable of copy / move / makedir et=
c.

>* You define the dtd as a static QString, better define it simply as con=
st
>char * and create a QString from it in the constructor. (Or when first u=
sed)

Ok. I currently haven't figured out how to make use of the dtd, if at all=
, so=20
it may just get removed anyway.

>* There is code like:
>          data( m_bufReceive );
>          if ( dataInternal )
>            m_intData +=3D m_bufReceive;
>
>I don't think that such internal data should be sent back to the applica=
tion
>should it? E.g. I would rather expect something like:
>if (dataInternal)
>   m_intData +=3D m_bufReceive;
>else
>  data(m_bufReceive);

That's what I had originally; it got pretty complex and I wanted to keep =
the=20
patch simple. The only reason to send the data back to the application as=
=20
well is to allow it to receive the properties from the returned xml as we=
ll,=20
and there's got to be a better way to do that. I'll put it back that way;=
=20
should I do the same for the totalSize(), processedSize() etc calls?

I'm pretty stuck on what to do re. locking files; how can I present some=20
interface to allow this in konqueror? Plus, remembering lock tokens would=
=20
need to be done by one of: the interface program (konqueror, quanta+), an=
=20
independant program (could kdesud be extended to store per-url properties=
?),=20
saved to a file (kio_webdavrc?), or added to the url (eg.=20
webdav://server/file?locktoken=3D2t3h5x32nt5h32).

Another question on konqueror generally - where are the KFilePlugins stor=
ed?

Cheers,
Hamish