[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch + examples, change frameset.rows from js
From:       <koos.vriezen () xs4all ! nl>
Date:       2001-12-26 16:45:44
[Download RAW message or body]

> > Just wanted to fix the frameset.rows.
>
> It made you fix cross-frames changes much more generally ;-))

Now that this is fixed and the removal of the copy of the m_rows of
HTMLFrameSetElementImpl in RenderFrameSet, it seems that calling
'setChanged' in HTMLFrameSetElementImpl::parseAttribute is redundant.
'AttrImpl::setValue' (line 230):
    if (_element) {
        _element->parseAttribute(this);
        _element->setChanged(true);
already does that. So

--- html/html_baseimpl.cpp.orig Wed Dec 26 16:51:50 2001
+++ html/html_baseimpl.cpp      Wed Dec 26 16:52:13 2001
@@ -388,13 +388,11 @@
         delete m_rows;
         m_rows = attr->val()->toLengthList();
         m_totalRows = m_rows->count();
-        setChanged();
         break;
     case ATTR_COLS:
         delete m_cols;
         m_cols = attr->val()->toLengthList();
         m_totalCols = m_cols->count();
-        setChanged();
         break;
     case ATTR_FRAMEBORDER:
         // false or "no" or "0"..

is a small cleanup.

Regards,

Koos Vriezen



[prev in list] [next in list] [prev in thread] [next in thread]