[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch + examples, change frameset.rows from js
From:       <koos.vriezen () xs4all ! nl>
Date:       2001-12-24 0:20:49
[Download RAW message or body]

> > > Does a call to setChanged on a DocumentImpl node, add this node twice to
> > > changedNodes? (Maybe QList is smart enough for not adding thing twice)
> No, a QList can have duplicates, so indeed we have to do that check ourselves
>
> > > void NodeImpl::setChanged(bool b)
> > > {
> > >     if (b && !attached()) // changed compared to what?
> > >         return;
> > >     if (b && !changed() && ownerDocument())
> The !changed() here is what tells me that we're not appending twice...
> But I'm not 100% sure of that reasoning, need to look at this stuff closer once again :}

You right if ownerDocument() return NULL for a DocumentImpl

> Thanks for the patch, I have applied it.

Just wanted to fix the frameset.rows.
Thanks for applying it.

Regards,

Koos Vriezen

[prev in list] [next in list] [prev in thread] [next in thread]