[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch + examples, change frameset.rows from js
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-12-23 0:10:29
[Download RAW message or body]

On Saturday 22 December 2001 00:19, koos.vriezen@xs4all.nl wrote:
> @@ -1519,10 +1520,11 @@
>  void NodeBaseImpl::applyChanges(bool top, bool force)
>  {
> 
> -    setChanged(false);
> 
> -    if (!attached())
> +    if (!attached()) {
> +           setChanged(false);
>             return;
> +    }
> 
>      int ow = (m_style?m_style->outlineWidth():0);

Another setChanged(false) before the next return; was missing, fixed.

> Probably the change from
> 'd->m_doc->updateRendering()' to
> 'DocumentImpl::updateDocumentsRendering()'
> should be done on more places where js is executed.

Right - did that too, to fix the "strange KJS-frames" report on this list.

Thanks for the patch!
Please update from CVS and test if the current version still works for
your frameset.rows case (I haven't tested that one).

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://www.kde.org/people/david.html (my real webpage is down)
KDE 3.0: Konquering the Desktops
[prev in list] [next in list] [prev in thread] [next in thread]