[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: patch + examples, change frameset.rows from js
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-12-20 17:24:07
[Download RAW message or body]

On Thursday 20 December 2001 18:17, koos.vriezen@xs4all.nl wrote:
> void NodeBaseImpl::applyChanges(bool top, bool force)
> {
> 
>     setChanged(false);
>     ^^^^^^^^^^^^^^^^^
>     if (!attached())
> 	    return;
> 
>     int ow = (m_style?m_style->outlineWidth():0);
> 
>     if (top)
>         recalcStyle();
> 
>     // a style change can influence the children, so we just go
>     // through them and trigger an appplyChanges there too
>     NodeImpl *n = _first;
>     while(n) {
>         n->applyChanges(false,force || changed());
>         n = n->nextSibling();          ^^^^^^^^^
>     }

Maybe this should be || n->changed() here ?
I'm not sure what the logic aims to be.... (Dirk knows ;)

>[...]
> I think the line 'setChanged(false);' should be removed here.

At least in the above code it can't be completely removed, but
maybe simple moved inside the if(!attached()) case - in such a
case we want to clear the changed bool (IIRC I had problems with
that in the past).

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://www.kde.org/people/david.html (my real webpage is down)
KDE 3.0: Konquering the Desktops
[prev in list] [next in list] [prev in thread] [next in thread]