[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: kjs bug (onSubmit related)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-10-18 19:21:30
[Download RAW message or body]

On Vendredi 27 Juillet 2001 00:00, Michael Bayne wrote:
> So recently onSubmit wasn't doing the right thing with functions that
> returned false (or true, or anything for that matter).
> [....]
> Index: internal.cpp
> ===================================================================
> RCS file: /home/kde/kdelibs/kjs/internal.cpp,v
> retrieving revision 1.79
> diff -u -p -r1.79 internal.cpp
> --- internal.cpp        2001/07/23 18:17:54     1.79
> +++ internal.cpp        2001/07/26 21:13:29
> @@ -760,9 +760,12 @@ bool KJScriptImp::call(const KJSO &func,
> 
>    running++;
>    recursion++;
> -  func.executeCall(thisV, &args, &extraScope);
> +  KJSO res = func.executeCall(thisV, &args, &extraScope);
>    recursion--;
>    running--;
> +
> +  // keep track of the return value
> +  retVal = res.imp();
> 
>    return !hadException();
>  }
> 
> I've applied this and it seems to do the right thing, but I don't know
> much about reference counting KJSO instances and all that, so perhaps
> something more sophisticated needs be done.
> 
> In any event, hopefully porten or pmk are reading this since they seem to
> be the ones that do the most work on the kjs and ECMA stuff.
 
Wow, it's been a long time already :}

Looking at internal.cpp, I see that the above still isn't in.
I wonder if it's still necessary though - do you have a testcase for the
problem you mention, so that I could check ? Alternatively, test the
code from CVS and tell me if the problem is still there.

Thanks,
David.

[prev in list] [next in list] [prev in thread] [next in thread]