[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    PATCH: Fix a crash, when external references are disabled
From:       Michael =?iso-8859-1?q?H=E4ckel?= <Michael () Haeckel ! Net>
Date:       2001-09-26 12:37:10
[Download RAW message or body]

Hi,

Attached patch prevents KMail from crashing, when external references are 
disabled and the mail contains an external style sheet.
It would be nice, to have it in both branches.

Regards,
Michael Häckel
["css.diff" (text/x-diff)]

Index: css_ruleimpl.cpp
===================================================================
RCS file: /home/kde/kdelibs/khtml/css/css_ruleimpl.cpp,v
retrieving revision 1.21
diff -u -3 -p -r1.21 css_ruleimpl.cpp
--- css_ruleimpl.cpp	2001/09/26 09:04:02	1.21
+++ css_ruleimpl.cpp	2001/09/26 12:32:29
@@ -134,15 +134,18 @@ CSSImportRuleImpl::CSSImportRuleImpl(Sty
     // ### pass correct charset here!!
     m_cachedSheet = docLoader->requestStyleSheet(absHref, QString::null);
 
-    m_cachedSheet->ref(this);
-    m_loading = true;
+    if (m_cachedSheet)
+    {
+      m_cachedSheet->ref(this);
+      m_loading = true;
+    }
 }
 
 CSSImportRuleImpl::~CSSImportRuleImpl()
 {
     if(m_lstMedia) m_lstMedia->deref();
     if(m_styleSheet) m_styleSheet->deref();
-    m_cachedSheet->deref(this);
+    if(m_cachedSheet) m_cachedSheet->deref(this);
 }
 
 DOMString CSSImportRuleImpl::href() const


[prev in list] [next in list] [prev in thread] [next in thread]