[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kfm-devel
Subject:    Re: nsplugin improvements
From:       David Bishop <david () bishop ! dhs ! org>
Date:       2001-09-11 16:50:45
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


I never saw a follow-up to this email, has anything happened on this front?  
I dislike having to open netscape to surf adcritic.com :)

D.A.Bishop

On Wednesday 05 September 2001 10:10 am, Jeremy White wrote:
> The nsplugin support in Konqueror has a few bugs which prevent
> CrossOver Plugin from working correctly.
>
> I've worked out a patch which resolves these problems, and
> I've sent it privately to Stefan (he had reviewed and 'blessed'
> an earlier patch of mine).  However, either my email for
> Stefan is bad, or he's out of the loop, because I haven't heard
> back from him for quite some time.
>
> There are two basic bugs that are addressed.  First,
> nsplugin was never providing the 'end' field to a child
> plugin (end gives the total file size).  This was making
> Shockwave/Director throw a hissy fit.  Second, nsplugin
> was not obtaining the mime type for a stream that was
> generated via an NPN_GetURL.  This prevents the trailers
> at quicktime.com from working (because you click on 'em
> to see the 'real' movie).
>
> To be honest, I'm not entirely certain that my implementation
> is the best one, and I wouldn't mind some code review.
> Specifically, in order to get the mimeType for a new stream,
> I connected a slot to the mimetype signal, and then stored
> the resulting mimetype in a local variable.  Same for
> the _end.  Arguably, I could have modified the TransferJob class to
> create an accessor function for the mimetype and just used that.
> However, I wanted to keep my changes very localized to
> the nsplugin stuff, so I hesitated to make that change.
>
> Thanks for listening,
>
> Jeremy
>
>
> Changelog:
>      Provide a correct 'end' in all stream related NPP calls.
>      Provide a correct mimetype in streams created by NPP_GetURL.
>      Switch to new method for determining default User Agent.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7nk7eKEJ4huP2XBERAkxkAJ46AhuBVhV0M8NKvYy61N3UQOPzNgCeLB5J
YLg7klASJ6tnetXtju3HQgI=
=DhgJ
-----END PGP SIGNATURE-----

[prev in list] [next in list] [prev in thread] [next in thread]