[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kexec
Subject:    Re: [PATCH v3 0/4] kexec/arm64: Fix issue with 'kexec load' and 'kdump' when --dtb option is used
From:       Bhupesh Sharma <bhsharma () redhat ! com>
Date:       2018-12-26 4:53:52
Message-ID: CACi5LpOsT1UcXjB4NFV9n62nZWy=HJ6Qt_hFWT5UktCjtLToZg () mail ! gmail ! com
[Download RAW message or body]

Hello Vicenç,

On Mon, Dec 17, 2018 at 12:47 AM Bhupesh Sharma <bhsharma@redhat.com> wrote:
>
> Changes since v2:
> -----------------
>  - Dropped 4/4 from v2 as I noticed that we pass wrong node name to fdt
>    helper functions in 'kexec/dt-ops.c'
>
> This patchset fixes some issues when we call kexec for arm64 with --dtb
> option (both for 'kexec load' and 'kdump' use cases).
>
> A couple of these issues were reported for 'kexec load' use case by
> Vicenç and I found the other two while experiment with 'kdump' use
> cases.
>
> I have tested the patchset on my qualcomm-amberwing and hp-moonshot
> arm64 boards.
>
> Cc: Simon Horman <horms@verge.net.au>
> Cc: AKASHI Takahiro <takahiro.akashi@linaro.org>
> Cc: Vicente Bergas <vicencb@gmail.com>
>
> Bhupesh Sharma (4):
>   kexec/dt-ops.c: Fix check against 'fdt_add_subnode' return value
>   kexec/kexec-arm64.c: Add error handling check against return value of
>     'set_bootargs()'
>   kexec/dt-ops.c: Fix adding '/chosen' node for cases where it is not
>     available in dtb passed via --dtb option
>   kexec/dt-ops.c: Fix '/chosen' v/s 'chosen' node being passed to fdt
>     helper functions
>
>  kexec/arch/arm64/kexec-arm64.c |  5 +++++
>  kexec/dt-ops.c                 | 36 ++++++++++++++++++++++++++++++------
>  2 files changed, 35 insertions(+), 6 deletions(-)
>
> --
> 2.7.4
>

Can you please give this patchset a try at your end and see if it
fixes the issues you had reported with the --dtb option.

Thanks,
Bhupesh

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

[prev in list] [next in list] [prev in thread] [next in thread]