[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kexec
Subject:    Re: [PATCH] ppc64/kdump: Fix ELF header endianess
From:       Petr Tesarik <ptesarik () suse ! cz>
Date:       2014-07-29 6:33:50
Message-ID: 20140729083350.76dd3813 () hananiah ! suse ! cz
[Download RAW message or body]

On Fri, 25 Jul 2014 17:07:49 +0200
Laurent Dufour <ldufour@linux.vnet.ibm.com> wrote:

> The ELF header created among the loading of the kdump kernel should be
> flagged using the current endianess and not always as big endian.
> 
> Without this patch the data exposed in /proc/vmcore are not readable when
> running in LE mode.

FWIW I can confirm that this patch has fixed kdump on my ppc64le system.

Thank you, Laurent!

Petr Tesarik

> Signed-off-by: Laurent Dufour <ldufour@linux.vnet.ibm.com>
> ---
>  kexec/arch/ppc64/crashdump-ppc64.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kexec/arch/ppc64/crashdump-ppc64.c b/kexec/arch/ppc64/crashdump-ppc64.c
> index 00a0e632f48e..6214b831fdf2 100644
> --- a/kexec/arch/ppc64/crashdump-ppc64.c
> +++ b/kexec/arch/ppc64/crashdump-ppc64.c
> @@ -38,7 +38,11 @@
>  static struct crash_elf_info elf_info64 =
>  {
>  	class: ELFCLASS64,
> +#if BYTE_ORDER == LITTLE_ENDIAN
> +	data: ELFDATA2LSB,
> +#else
>  	data: ELFDATA2MSB,
> +#endif
>  	machine: EM_PPC64,
>  	page_offset: PAGE_OFFSET,
>  	lowmem_limit: MAXMEM,
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
[prev in list] [next in list] [prev in thread] [next in thread]