[prev in list] [next in list] [prev in thread] [next in thread]
List: kexec
Subject: Re: [PATCH] kexec: add further check to crashkernel
From: ebiederm () xmission ! com (Eric W ! Biederman)
Date: 2012-03-13 18:27:30
Message-ID: m1r4wwe4q5.fsf () fess ! ebiederm ! org
[Download RAW message or body]
DuanZhenzhong <zhenzhong.duan@oracle.com> writes:
> From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>
> When add crashkernel=2M-256M, kernel don't give any warning.
> This is misleading sometimes.
That seems reasonable.
Andrew do you want to carry this one. I don't have a good tree to stash
this in.
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> ---
> kernel/kexec.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7b08867..0a6d147 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1359,6 +1359,10 @@ static int __init parse_crashkernel_simple(char *cmdline,
>
> if (*cur == '@')
> *crash_base = memparse(cur+1, &cur);
> + else if (*cur != ' ' && *cur != '\0') {
> + pr_warning("crashkernel: unrecognized char\n");
> + return -EINVAL;
> + }
>
> return 0;
> }
> -- 1.7.3
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic