[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kexec
Subject:    [PATCH] x86_64 purgatory Makefile typo fix.
From:       horms () verge ! net ! au (Simon Horman)
Date:       2008-03-18 3:03:19
Message-ID: 20080318030317.GA12309 () verge ! net ! au
[Download RAW message or body]

On Mon, Mar 17, 2008 at 10:07:36AM +0100, Bernhard Walle wrote:
> Hi Simon,
> 
> * Simon Horman [2008-03-17 01:49]:
> > 
> > Ooops, sorry about that.
> > 
> > Perhaps this is worthy of a fresh release?
> 
> IMO yes since the current release is unusable on x86_64. But please make
> sure to also include the
> 
> ?1. The distribution missed the files
> 
> ? ? ? ? purgatory/arch/x86_64/entry64-32.S,
> ? ? ? ? purgatory/arch/x86_64/entry64.S,
> ? ? ? ? purgatory/arch/x86_64/setup-x86_64.S,
> ? ? ? ? purgatory/arch/x86_64/stack.S,
> ? ? ? ? purgatory/arch/x86_64/purgatory-x86_64.c
> 
> ? ? The problem was that variable expansion in a Makefile is a bit   
>     different from the expectation, i.e. the final value is used even if
>     the variable is used in the middle.
> 
> part of my fix.

Thanks, I wasn't aware that was how make variables work.
I've merged your change.

-- 
Horms



[prev in list] [next in list] [prev in thread] [next in thread]