[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    Re: [PATCH] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()
From:       Markus Elfring <Markus.Elfring () web ! de>
Date:       2024-05-17 14:18:06
Message-ID: 1d470a85-dd92-44d6-9900-db4c581b68c4 () web ! de
[Download RAW message or body]

> In tpmi_sst_dev_remove(), tpmi_sst is dereferenced after being freed. Fix this by reordering the kfree() post the dereference.

I suggest to take preferred line lengths better into account
also for such a change description.
Thus the second sentence should be put into a subsequent line.
How do you think about the following wording approach?

   Move a kfree() call behind an assignment statement in the affected if branch.

Regards,
Markus

[prev in list] [next in list] [prev in thread] [next in thread]