[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-kernel
Subject:    AW: [PATCH] wifi: ath12k: Remove some dead code
From:       Walter Harms <wharms () bfs ! de>
Date:       2023-04-25 12:10:31
Message-ID: d0c5ed33fb1644328fbdc5d7aba20a97 () bfs ! de
[Download RAW message or body]

Does  mcs = ATH12K_HE_MCS_MAX make sense ?

re,
 wh
________________________________________
Von: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Gesendet: Dienstag, 25. April 2023 13:57:19
An: Kalle Valo; David S. Miller; Eric Dumazet; Jakub Kicinski; Paolo Abeni
Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe \
JAILLET; ath12k@lists.infradead.org; linux-wireless@vger.kernel.org; \
                netdev@vger.kernel.org
Betreff: [PATCH] wifi: ath12k: Remove some dead code

ATH12K_HE_MCS_MAX = 11, so this test and the following one are the same.
Remove the one with the hard coded 11 value.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/net/wireless/ath/ath12k/dp_rx.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c \
b/drivers/net/wireless/ath/ath12k/dp_rx.c index e78478a5b978..79386562562f 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -1362,11 +1362,6 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar,
         * Firmware rate's control to be skipped for this?
         */

-       if (flags == WMI_RATE_PREAMBLE_HE && mcs > 11) {
-               ath12k_warn(ab, "Invalid HE mcs %d peer stats",  mcs);
-               return;
-       }
-
        if (flags == WMI_RATE_PREAMBLE_HE && mcs > ATH12K_HE_MCS_MAX) {
                ath12k_warn(ab, "Invalid HE mcs %d peer stats",  mcs);
                return;
--
2.34.1


[prev in list] [next in list] [prev in thread] [next in thread]