[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH] i2c: xlr: Fix a resource leak in the error handling path of 'xlr_i2c_probe()'
From:       Wolfram Sang <wsa () kernel ! org>
Date:       2021-10-29 20:05:55
Message-ID: YXxUIw02XJqVvus3 () kunai
[Download RAW message or body]


On Thu, Aug 19, 2021 at 10:48:08PM +0200, Christophe JAILLET wrote:
> A successful 'clk_prepare()' call should be balanced by a corresponding
> 'clk_unprepare()' call in the error handling path of the probe, as already
> done in the remove function.
> 
> More specifically, 'clk_prepare_enable()' is used, but 'clk_disable()' is
> also already called. So just the unprepare step has still to be done.
> 
> Update the error handling path accordingly.
> 
> Fixes: 75d31c2372e4 ("i2c: xlr: add support for Sigma Designs controller variant")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied to for-next, thanks!


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]