[prev in list] [next in list] [prev in thread] [next in thread]
List: kernel-janitors
Subject: Re: [PATCH][next] netfilter: nf_tables: Fix dereference of null pointer flow
From: Pablo Neira Ayuso <pablo () netfilter ! org>
Date: 2021-07-02 0:56:48
Message-ID: 20210702005648.GC29227 () salvia
[Download RAW message or body]
On Thu, Jun 24, 2021 at 08:57:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where chain->flags & NFT_CHAIN_HW_OFFLOAD is false then
> nft_flow_rule_create is not called and flow is NULL. The subsequent
> error handling execution via label err_destroy_flow_rule will lead
> to a null pointer dereference on flow when calling nft_flow_rule_destroy.
> Since the error path to err_destroy_flow_rule has to cater for null
> and non-null flows, only call nft_flow_rule_destroy if flow is non-null
> to fix this issue.
Applied, thanks.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic