[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH] ALSA: ctxfi: cthw20k2: fix mask on conf to allow 4 bits
From:       Takashi Iwai <tiwai () suse ! de>
Date:       2021-02-28 8:12:54
Message-ID: s5h8s78liex.wl-tiwai () suse ! de
[Download RAW message or body]

On Sat, 27 Feb 2021 01:15:27 +0100,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the mask operation on variable conf is just 3 bits so
> the switch statement case value of 8 is unreachable dead code.
> The function daio_mgr_dao_init can be passed a 4 bit value,
> function dao_rsc_init calls it with conf set to:
> 
>      conf = (desc->msr & 0x7) | (desc->passthru << 3);
> 
> so clearly when desc->passthru is set to 1 then conf can be
> at least 8.
> 
> Fix this by changing the mask to 0xf.
> 
> Fixes: 8cc72361481f ("ALSA: SB X-Fi driver merge")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.


Takashi
[prev in list] [next in list] [prev in thread] [next in thread]