[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    [PATCH] ide: Prevent some negative shifts in ide_set_ignore_cable()
From:       Dan Carpenter <dan.carpenter () oracle ! com>
Date:       2020-10-30 11:51:02
Message-ID: 20201030115102.GE3251003 () mwanda
[Download RAW message or body]

Shifting by a negative number is undefined.  These values come from the
module parameter, so it's not a big deal from a practical perspective.

Fixes: 9fd91d959f1a ("ide: add "ignore_cable" parameter (take 2)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/ide/ide.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
index 9a9c64fd1032..dcfb8a187c46 100644
--- a/drivers/ide/ide.c
+++ b/drivers/ide/ide.c
@@ -338,7 +338,7 @@ static int ide_set_ignore_cable(const char *s, const struct kernel_param *kp)
 	if (sscanf(s, "%d:%d", &i, &j) != 2 && sscanf(s, "%d", &i) != 1)
 		return -EINVAL;
 
-	if (i >= MAX_HWIFS || j < 0 || j > 1)
+	if (i < 0 || i >= MAX_HWIFS || j < 0 || j > 1)
 		return -EINVAL;
 
 	if (j)
-- 
2.28.0

[prev in list] [next in list] [prev in thread] [next in thread]