[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH] ASoC: mxs-saif: Add variable dev to simplify code
From:       Markus Elfring <Markus.Elfring () web ! de>
Date:       2020-04-30 6:36:00
Message-ID: a397e9c0-343c-685a-dd3f-53be09429a70 () web ! de
[Download RAW message or body]

> Add variable 'dev' to make the code cleaner in the function
> mxs_saif_probe(). And now that the function mxs_saif_mclk_init()
> have defined the variables 'ret' as the error returned value,
> then it should be used instead in this place.

I find it clearer to integrate such source code adjustments by separate patches
together with improved commit messages.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n138



Would you become interested to search for similar update candidates
by the means of the semantic patch language (Coccinelle software)?

Regards,
Markus


[prev in list] [next in list] [prev in thread] [next in thread]