[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH] staging: rtl8712: assign initial value to a static variable in r8712_efuse_pg_packet_wri
From:       maowenan <maowenan () huawei ! com>
Date:       2019-02-28 9:26:53
Message-ID: a7826f72-adb1-a7be-4397-64cd79d6ec67 () huawei ! com
[Download RAW message or body]



On 2019/2/28 16:04, Greg KH wrote:
> On Wed, Feb 27, 2019 at 11:33:22AM +0800, Mao Wenan wrote:
>> repeat_times is a static variable, but each time when it enters
>> r8712_efuse_pg_packet_write(), it is set to zero,
>> this value is not consistent with last calling, so next behavior
>> is not our expect.
>>
>> Signed-off-by: Mao Wenan <maowenan@huawei.com>
>> ---
>>  drivers/staging/rtl8712/rtl8712_efuse.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c
>> index 8bc45ffd3029..3e8421255170 100644
>> --- a/drivers/staging/rtl8712/rtl8712_efuse.c
>> +++ b/drivers/staging/rtl8712/rtl8712_efuse.c
>> @@ -358,7 +358,7 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
>>  	u8 pg_header = 0;
>>  	u16 efuse_addr = 0, curr_size = 0;
>>  	u8 efuse_data, target_word_cnts = 0;
>> -	static int repeat_times;
>> +	static int repeat_times = 0;
>>  	int sub_repeat;
>>  	u8 bResult = true;
>>  
>> @@ -368,7 +368,6 @@ u8 r8712_efuse_pg_packet_write(struct _adapter *padapter, const u8 offset,
>>  		return false;
>>  	pg_header = MAKE_EFUSE_HEADER(offset, word_en);
>>  	target_word_cnts = calculate_word_cnts(word_en);
>> -	repeat_times = 0;
>>  	efuse_addr = 0;
>>  	while (efuse_addr < efuse_available_max_size) {
>>  		curr_size = r8712_efuse_get_current_size(padapter);
> 
> This patch does not apply to my tree at all.
> 
> And are you sure this is correct?

sorry, my base tree is wrong, this fix is invalid.

> 
> greg k-h
> 
> .
> 

[prev in list] [next in list] [prev in thread] [next in thread]