[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH][net-next] net: qualcomm: rmnet: remove unused variable priv
From:       Subash Abhinov Kasiviswanathan <subashab () codeaurora ! org>
Date:       2017-08-31 20:34:20
Message-ID: a3a3328009e7c0ca8d910e1b15ad0b2a () codeaurora ! org
[Download RAW message or body]

On 2017-08-31 08:07, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> priv is being assigned but is never used, so remove it.
> 
> Cleans up clang build warning:
> "warning: Value stored to 'priv' is never read"
> 
> Fixes: ceed73a2cf4a ("drivers: net: ethernet: qualcomm: rmnet: Initial
> implementation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> index c8b573d28dcf..bf7455fdafcc 100644
> --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_vnd.c
> @@ -73,9 +73,6 @@ static const struct net_device_ops rmnet_vnd_ops = {
>   */
>  void rmnet_vnd_setup(struct net_device *rmnet_dev)
>  {
> -	struct rmnet_priv *priv;
> -
> -	priv = netdev_priv(rmnet_dev);
>  	netdev_dbg(rmnet_dev, "Setting up device %s\n", rmnet_dev->name);
> 
>  	rmnet_dev->netdev_ops = &rmnet_vnd_ops;

Thanks for fixing this.

Acked-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]