[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    [patch 1/2] staging: rtl8188eu: off by one in rtw_set_802_11_add_wep()
From:       Dan Carpenter <dan.carpenter () oracle ! com>
Date:       2013-08-29 21:45:42
Message-ID: 20130829214542.GB23197 () elgon ! mountain
[Download RAW message or body]

"keyid" is used as an offset into the ->dot11DefKey[] array.  The array
has 4 elements.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c \
b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c index 9e12774..5fab477 100644
--- a/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8188eu/core/rtw_ioctl_set.c
@@ -566,7 +566,7 @@ _func_enter_;
 
 	keyid = wep->KeyIndex & 0x3fffffff;
 
-	if (keyid > 4) {
+	if (keyid >= 4) {
 		RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_err_, \
("MgntActrtw_set_802_11_add_wep:keyid>4 =>fail\n"));  ret = false;
 		goto exit;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[prev in list] [next in list] [prev in thread] [next in thread]