[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [patch] [SCSI] mptfusion: unlock on error in mpt_config()
From:       Dan Carpenter <error27 () gmail ! com>
Date:       2012-04-30 7:58:21
Message-ID: CA+_b7DJn_Nnx=NQKOfQawpy9Q_306P5dUc=nYCqA8wf4YJiX=A () mail ! gmail ! com
[Download RAW message or body]

Ping?

regards,
dan carpenter

On 8/30/11, Nandigama, Nagalakshmi <Nagalakshmi.Nandigama@lsi.com> wrote:
> The patch seem to be fine. Please consider this patch as Acked-by:
> "Nandigama, Nagalakshmi" <Nagalakshmi.Nandigama@lsi.com>
>
>
> Regards,
> Nagalakshmi
>
>
> -----Original Message-----
> From: Dan Carpenter [mailto:error27@gmail.com]
> Sent: Saturday, August 27, 2011 3:30 PM
> To: Moore, Eric; Desai, Kashyap
> Cc: Support; DL-MPT Fusion Linux; open list:LSILOGIC MPT FUSI...;
> kernel-janitors@vger.kernel.org
> Subject: [patch] [SCSI] mptfusion: unlock on error in mpt_config()
>
> We introduced a new return here and forgot to unlock the mutex.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
> index e9c6a60..e72320e 100644
> --- a/drivers/message/fusion/mptbase.c
> +++ b/drivers/message/fusion/mptbase.c
> @@ -6482,6 +6482,7 @@ mpt_config(MPT_ADAPTER *ioc, CONFIGPARMS *pCfg)
>  				printk(MYIOC_s_INFO_FMT "%s: host reset in"
>  					" progress mpt_config timed out.!!\n",
>  					__func__, ioc->name);
> +				mutex_unlock(&ioc->mptbase_cmds.mutex);
>  				return -EFAULT;
>  			}
>  			spin_unlock_irqrestore(&ioc->taskmgmt_lock, flags);
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]