[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [patch] [media] rc: double unlock in rc_register_device()
From:       Jarod Wilson <jarod () redhat ! com>
Date:       2011-05-26 14:49:16
Message-ID: 4DDE686C.6000900 () redhat ! com
[Download RAW message or body]

Dan Carpenter wrote:
> If change_protocol() fails and we goto out_raw, then it calls unlock
> twice.

Gah, good catch, I gotta quit adding new bugs... ;)


> I noticed that the other time we called change_protocol() we
> held the &dev->lock, so I changed it to hold it here too.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
> ---
> Compile tested only.


I've sanity-checked the code, and yeah, calling change_protocol() 
function pointers with the lock held should be perfectly fine here too. 
The change_protocol functions are device-driver-specific, and don't 
touch the core rc device lock.

Reviewed-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com


--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]