[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [PATCH] staging: crystalhd: fix signed bug
From:       Jarod Wilson <jarod () redhat ! com>
Date:       2010-09-28 19:01:26
Message-ID: 20100928190126.GG8726 () redhat ! com
[Download RAW message or body]

On Sun, Sep 12, 2010 at 10:56:51PM +0400, Vasiliy Kulikov wrote:
> chd_dec_major is unsigned, so check chd_dec_major < 0 doesn't make sense.
> Since it is used as signed, declare it as int.
> 
> Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>

Indeed, Bad Things here when we try to store the ret from register_chrdev
in an unsigned int and test it for < 0...

Acked-by: Jarod Wilson <jarod@redhat.com>

-- 
Jarod Wilson
jarod@redhat.com

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]