[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitors
Subject:    Re: [KJ] [PATCH] lcd: fix memory leak, code cleanup
From:       walter harms <wharms () bfs ! de>
Date:       2004-12-21 8:15:50
Message-ID: 41C7DBB6.8070105 () bfs ! de
[Download RAW message or body]

Hi James,
misc_register() can fail.

ret=misc_register(&lcd_dev);

if (ret < 0) {
	pr_info("misc_register failed in %s\n",__FUNCTION__);
	return -ENOMEM;
	}

re,
walter



>  	}
>  
> @@ -613,7 +615,7 @@
>  {
>  	unsigned long data;
>  
> -	printk("%s\n", LCD_DRIVER);
> +	pr_info("%s\n", LCD_DRIVER);
>  	misc_register(&lcd_dev);
>  
>  	/* Check region? Naaah! Just snarf it up. */
> @@ -623,7 +625,7 @@
>  	data = LCDReadData;
>  	if ((data & 0x000000FF) == (0x00)) {
>  		lcd_present = 0;
> -		printk("LCD Not Present\n");
> +		pr_info(LCD "LCD Not Present\n");
>  	} else {
>  		lcd_present = 1;
>  		WRITE_GAL(kGal_DevBank2PReg, kGal_DevBank2Cfg);


_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors


[prev in list] [next in list] [prev in thread] [next in thread]