[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-janitor-commits
Subject:    kernel-janitor TODO,1.10,1.11
From:       Arnaldo Carvalho de Melo <patch () users ! sourceforge ! net>
Date:       2001-06-17 20:45:31
[Download RAW message or body]

Update of /cvsroot/kernel-janitor/kernel-janitor
In directory usw-pr-cvs1:/tmp/cvs-serv7087

Modified Files:
	TODO 
Log Message:
Clarify the sizeof entry, thanks to jgarzik


Index: TODO
===================================================================
RCS file: /cvsroot/kernel-janitor/kernel-janitor/TODO,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- TODO	2001/06/17 03:25:26	1.10
+++ TODO	2001/06/17 20:45:29	1.11
@@ -451,4 +451,12 @@
 - when using sizeof consider using the variable and not the type, that way
   if the type of the variable is changed we don't have to go seaching all
   instances of sizeof(type)
+
+Comments by jgarzik:
+
+That's kind of misleading... it should be sizeof(*var) not sizeof(var)
+in most cases.
+
+acme: yes, better clarify, if its a pointer you have to follow Jeff tip above
+and use sizeof(*var)
 ------------------------------------------------------------------------


_______________________________________________
Kernel-janitor-commits mailing list
Kernel-janitor-commits@lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/kernel-janitor-commits

[prev in list] [next in list] [prev in thread] [next in thread]