[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-hardening
Subject:    [kernel-hardening] Re: [PATCH V8 2/2] printk: hash addresses printed with %p
From:       "Tobin C. Harding" <me () tobin ! cc>
Date:       2017-10-31 2:00:05
Message-ID: 20171031020005.GC12341 () eros
[Download RAW message or body]

On Mon, Oct 30, 2017 at 08:00:46PM -0400, Steven Rostedt wrote:
> On Tue, 31 Oct 2017 09:41:02 +1100
> "Tobin C. Harding" <me@tobin.cc> wrote:
> 
> 
> > Cool. So I think we need
> > 
> >  	get_random_bytes(&ptr_key, sizeof(ptr_key));
> 
> You'll need to add a comment here to describe what ordering the memory
> barrier is used against. That is, somewhere else there's something that
> needs to see the "true" after the "get_random_bytes" update. Describe
> it here.

Got it, thanks Tobin.
[prev in list] [next in list] [prev in thread] [next in thread]