[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kernel-hardening
Subject:    Re: [PATCH v3] module: extend 'rodata=off' boot cmdline parameter to module mappings
From:       AKASHI Takahiro <takahiro.akashi () linaro ! org>
Date:       2016-11-28 9:18:31
Message-ID: 20161128091830.GB23034 () linaro ! org
[Download RAW message or body]

On Mon, Nov 28, 2016 at 08:59:40AM +0100, Andreas Ziegler wrote:
> Hi Akashi,
> 
> your patch "module: extend 'rodata=off' boot cmdline parameter to module
> mappings" showed up in linux-next today, and I noticed a small error in it.
> 
> The first modified #ifdef is fine, the second one, however, has a spelling
> mistake in it: the CONFIG_ variable should be CONFIG_DEBUG_SET_MODULE_RONX
> instead of CONFIG_SET_MODULE_RONX (note the missing DEBUG).

Thank you for pointing this out.
(I didn't notice it because DEBUG_RODATA is always on on arm64.)

Rusty, Jessica, should I submit v4 to correct it?

-Takahiro AKASHI

> I noticed it by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which is essentialy diffing the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
> 
> Best regards,
> 
> Andreas

[prev in list] [next in list] [prev in thread] [next in thread]