List: kdevelop-devel
Subject: Re: Review Request: Fix regression in output filtering and improve the output
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-11-24 15:59:57
Message-ID: 20121124155957.10861.41833 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107446/#review22486
-----------------------------------------------------------
Ship it!
Besides those two minor issues looks good.
outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107446/#comment17216>
extra whitespace here at the end of the line.
outputview/outputfilteringstrategies.cpp
<http://git.reviewboard.kde.org/r/107446/#comment17217>
This could also be declared static if its used just in this file.
- Andreas Pakulat
On Nov. 24, 2012, 2:45 p.m., Morten Volden wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107446/
> -----------------------------------------------------------
> =
> (Updated Nov. 24, 2012, 2:45 p.m.)
> =
> =
> Review request for KDevelop.
> =
> =
> Description
> -------
> =
> The patch addresses two things:
> =
> a) Fix regression introduced after refactoring outputfiltering - It was n=
ot possible to click on linker errors
> b) Now indicates the linker errors as errors making it visible to the use=
r that he can click on them
> =
> Also a corrected one of the regular expressions so that it now hits on al=
l line instances it is supposed to hit on (Come to think of it, thats three=
things :-) )
> =
> =
> Diffs
> -----
> =
> outputview/outputfilteringstrategies.cpp 29f5b7e =
> outputview/tests/filteringstrategytest.cpp 0c54d43 =
> outputview/tests/testlinebuilderfunctions.h 919393e =
> =
> Diff: http://git.reviewboard.kde.org/r/107446/diff/
> =
> =
> Testing
> -------
> =
> Various tests in filteringstrategytest have been expanded with cases to v=
erify this.
> =
> =
> Screenshots
> -----------
> =
> Before
> http://git.reviewboard.kde.org/r/107446/s/852/
> After
> http://git.reviewboard.kde.org/r/107446/s/853/
> =
> =
> Thanks,
> =
> Morten Volden
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107446/">http://git.reviewboard.kde.org/r/107446/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Besides those two minor \
issues looks good.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107446/diff/1/?file=96089#file96089line66" \
style="color: black; font-weight: bold; text-decoration: \
underline;">outputview/outputfilteringstrategies.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
CompilerFilterStrategyPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c1">// All the possible string that indicate an error if we via Regex have \
been able to<span class="ew"> </span></span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">extra \
whitespace here at the end of the line.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/107446/diff/1/?file=96089#file96089line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">outputview/outputfilteringstrategies.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
CompilerFilterStrategyPrivate</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="k">const</span> <span class="n">QVector</span><span class="o"><</span><span \
class="n">QString</span><span class="o">></span> <span \
class="n">ERROR_INDICATORS</span> <span class="o">=</span> <span \
class="n">QVector</span><span class="o"><</span><span \
class="n">QString</span><span class="o">></span><span \
class="p">()</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This could \
also be declared static if its used just in this file.</pre> </div>
<br />
<p>- Andreas</p>
<br />
<p>On November 24th, 2012, 2:45 p.m., Morten Volden wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Morten Volden.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2012, 2:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch addresses two things:
a) Fix regression introduced after refactoring outputfiltering - It was not possible \
to click on linker errors b) Now indicates the linker errors as errors making it \
visible to the user that he can click on them
Also a corrected one of the regular expressions so that it now hits on all line \
instances it is supposed to hit on (Come to think of it, thats three things :-) \
)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Various tests in filteringstrategytest have been expanded with cases to \
verify this.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>outputview/outputfilteringstrategies.cpp <span style="color: \
grey">(29f5b7e)</span></li>
<li>outputview/tests/filteringstrategytest.cpp <span style="color: \
grey">(0c54d43)</span></li>
<li>outputview/tests/testlinebuilderfunctions.h <span style="color: \
grey">(919393e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107446/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107446/s/852/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/24/ScreenshotBefore_400x100.png" \
style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/107446/s/853/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/24/After_400x100.png" \
style="border: 1px black solid;" alt="After" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic