[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Shell integration: extend commands for syncing cwd
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-09-24 8:32:34
Message-ID: 20120924083234.4630.84132 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Sept. 24, 2012, 12:30 a.m., Aleix Pol Gonzalez wrote:
> > shell/projectcontroller.h, line 86
> > <http://git.reviewboard.kde.org/r/106508/diff/1/?file=86379#file86379line86>
> >
> > Why don't you use the findProjectForUrl thing?
Because thats not doing the same thing. Look at the implementation, the prefix is \
just a text, not an url.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106508/#review19370
-----------------------------------------------------------
On Sept. 19, 2012, 6:10 p.m., Ivan Shapovalov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106508/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2012, 6:10 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> This adds 2 new commands for syncing the shell working directory (in \
> kdevplatform_shell_environment.sh). These are
> - "project!", which navigates to the root directory of a project, and
> - "bdir!", which navigates to the build directory of a project (if one is returned \
> by the build manager).
> These commands take an optional argument - project name, which (if exists) is \
> handled as a target project name prefix and is collated in case-insensitive mode. \
> Thus, to navigate to kdevplatform's root directory one may type "project! kdevpl". \
> If that argument is not given, the project of currently open document is selected.
> Reason: I just found these commands useful. Maybe someone else also will.
>
>
> Diffs
> -----
>
> shell/projectcontroller.h e21345f
> shell/projectcontroller.cpp e5fe56f
> util/kdevplatform_shell_environment.sh d428f6c
>
> Diff: http://git.reviewboard.kde.org/r/106508/diff/
>
>
> Testing
> -------
>
> Used the newly-added commands for a sufficiently long time period (~2 weeks).
>
>
> Thanks,
>
> Ivan Shapovalov
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106508/">http://git.reviewboard.kde.org/r/106508/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On September 24th, 2012, 12:30 a.m., <b>Aleix Pol \
Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/106508/diff/1/?file=86379#file86379line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shell/projectcontroller.h</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KDEVPLATFORMSHELL_EXPORT ProjectController : public IProjectController</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">IProject</span><span class="o">*</span> <span \
class="n">findProjectByPrefix</span><span class="p">(</span> <span \
class="k">const</span> <span class="n">QString</span><span class="o">&</span> \
<span class="n">prefix</span> <span class="p">)</span> <span \
class="k">const</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why don't you use \
the findProjectForUrl thing?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Because \
thats not doing the same thing. Look at the implementation, the prefix is just a \
text, not an url.</pre> <br />
<p>- Andreas</p>
<br />
<p>On September 19th, 2012, 6:10 p.m., Ivan Shapovalov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ivan Shapovalov.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2012, 6:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This adds 2 new commands for syncing the shell working directory (in \
kdevplatform_shell_environment.sh). These are
- "project!", which navigates to the root directory of a project, and
- "bdir!", which navigates to the build directory of a project (if one is \
returned by the build manager).
These commands take an optional argument - project name, which (if exists) is handled \
as a target project name prefix and is collated in case-insensitive mode. Thus, to \
navigate to kdevplatform's root directory one may type "project! \
kdevpl". If that argument is not given, the project of currently open document \
is selected.
Reason: I just found these commands useful. Maybe someone else also will.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Used the newly-added commands for a sufficiently long time period (~2 \
weeks).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/projectcontroller.h <span style="color: grey">(e21345f)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(e5fe56f)</span></li>
<li>util/kdevplatform_shell_environment.sh <span style="color: \
grey">(d428f6c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106508/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic