[prev in list] [next in list] [prev in thread] [next in thread]
List: kdevelop-devel
Subject: Re: Review Request: Adding Shortcut F2 and Delete also F5 on Project Manager View
From: "Andreas Pakulat" <apaku () gmx ! de>
Date: 2012-09-21 8:33:18
Message-ID: 20120921083318.15498.78989 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106374/#review19257
-----------------------------------------------------------
Hmm, I don't think adding a non-working shortcut is of any use. So someone =
needs to sit down and find out why it doesn't work. If you cannot do this y=
ourself it would be nice if you could at least file a bugreport that adding=
the f5-shortcut only ever refereshes the fileview widget. Otherwise the pa=
tch looks fine.
- Andreas Pakulat
On Sept. 7, 2012, 7:35 p.m., Przemek Czekaj wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106374/
> -----------------------------------------------------------
> =
> (Updated Sept. 7, 2012, 7:35 p.m.)
> =
> =
> Review request for KDevelop.
> =
> =
> Description
> -------
> =
> It's a feature request to add to kdevelop, pressing F2 in the Project Tre=
e Widget on the folder or file, will trigger the rename window, pressing De=
lete will trigger remove dialog, pressing F5 should trigger reload but does=
n't get the focus on the widget :(
> =
> I do it, becasue a lot of editors have this shortcuts by default on the p=
roject tree view fe: eclipse, netbeans, jetbrains editors etc...
> =
> Regards.
> =
> =
> Diffs
> -----
> =
> plugins/projectmanagerview/projectmanagerviewplugin.cpp 968376d =
> =
> Diff: http://git.reviewboard.kde.org/r/106374/diff/
> =
> =
> Testing
> -------
> =
> compiled and tested, but the problem is with F5 on the Project Tree, it d=
oesn't get the focus on this widget, just refresh the file view widget (hav=
e no idea how should it be writed... so Im very sorry)
> =
> =
> Screenshots
> -----------
> =
> Context menu, show what patch add
> http://git.reviewboard.kde.org/r/106374/s/720/
> =
> =
> Thanks,
> =
> Przemek Czekaj
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106374/">http://git.reviewboard.kde.org/r/106374/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmm, I don't think \
adding a non-working shortcut is of any use. So someone needs to sit down and find \
out why it doesn't work. If you cannot do this yourself it would be nice if you \
could at least file a bugreport that adding the f5-shortcut only ever refereshes the \
fileview widget. Otherwise the patch looks fine.</pre> <br />
<p>- Andreas</p>
<br />
<p>On September 7th, 2012, 7:35 p.m., Przemek Czekaj wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Przemek Czekaj.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2012, 7:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It's a feature request to add to kdevelop, pressing F2 in the \
Project Tree Widget on the folder or file, will trigger the rename window, pressing \
Delete will trigger remove dialog, pressing F5 should trigger reload but doesn't \
get the focus on the widget :(
I do it, becasue a lot of editors have this shortcuts by default on the project tree \
view fe: eclipse, netbeans, jetbrains editors etc...
Regards.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled and tested, but the problem is with F5 on the Project Tree, it \
doesn't get the focus on this widget, just refresh the file view widget (have no \
idea how should it be writed... so Im very sorry)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/projectmanagerview/projectmanagerviewplugin.cpp <span style="color: \
grey">(968376d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106374/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106374/s/720/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/07/kdevplatform-patch_400x100.png" \
style="border: 1px black solid;" alt="Context menu, show what patch add" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
--
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic