[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: OpenWith - configuration dialog
From:       "Andreas Pakulat" <apaku () gmx ! de>
Date:       2012-09-09 18:41:04
Message-ID: 20120909184104.18917.5944 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106388/#review18744
-----------------------------------------------------------



plugins/openwith/openwithconfig.h
<http://git.reviewboard.kde.org/r/106388/#comment14856>

    This variable is badly names, the model is not a widget.



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14855>

    This should be using KDialog::Ok, since the dialog will be closed when clicking \
it. Apply is for situations where the config dialog is kept open but the settings are \
being applied.



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14857>

    This should use okClicked and then not use close() in the save() slot.



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14859>

    Why is the selection stored in a (not quite well named) variable? You could just \
query it in save(). Also the dialog should not allow to be closed with the checkbox \
unchecked and no item selected IMHO. So the ok button should be disabled accordingly.



plugins/openwith/openwithconfig.cpp
<http://git.reviewboard.kde.org/r/106388/#comment14858>

    This could be directly connected to the setDisabled slot of the services widget. \
No need for a separate slot here.



plugins/openwith/openwithconfig.ui
<http://git.reviewboard.kde.org/r/106388/#comment14852>

    Where does this locale setting come from and what consequences does it have?



plugins/openwith/openwithconfig.ui
<http://git.reviewboard.kde.org/r/106388/#comment14853>

    This layout is unecessary, you're merely nesting a vertical layout in another \
which does not make any sense.



plugins/openwith/openwithconfig.ui
<http://git.reviewboard.kde.org/r/106388/#comment14854>

    What does this option do? If its about opening the file embedded then why have a \
checkbox instead of listing the embedded editor plugins available. Last I looked at \
the code thats what was happening with the menu too.


- Andreas Pakulat


On Sept. 9, 2012, 11:36 a.m., Przemek Czekaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106388/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2012, 11:36 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Added a configuration dialog to the context menu.
> 
> 
> This addresses bug 287764.
> http://bugs.kde.org/show_bug.cgi?id=287764
> 
> 
> Diffs
> -----
> 
> plugins/openwith/CMakeLists.txt 8742aeb 
> plugins/openwith/openwithconfig.h PRE-CREATION 
> plugins/openwith/openwithconfig.cpp PRE-CREATION 
> plugins/openwith/openwithconfig.ui PRE-CREATION 
> plugins/openwith/openwithplugin.h 809a0e8 
> plugins/openwith/openwithplugin.cpp 69404ef 
> 
> Diff: http://git.reviewboard.kde.org/r/106388/diff/
> 
> 
> Testing
> -------
> 
> Compiled, and local install. Tested by hand.
> 
> 
> Screenshots
> -----------
> 
> OpenWith context menu
> http://git.reviewboard.kde.org/r/106388/s/722/
> Openwith dialog - internal option
> http://git.reviewboard.kde.org/r/106388/s/723/
> Open with - selectable list
> http://git.reviewboard.kde.org/r/106388/s/724/
> 
> 
> Thanks,
> 
> Przemek Czekaj
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106388/">http://git.reviewboard.kde.org/r/106388/</a>
  </td>
    </tr>
   </table>
   <br />









<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84305#file84305line51" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.h</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">private:</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">51</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">QStandardItemModel</span> <span class="o">*</span><span \
class="n">m_widget</span><span class="p">;</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This \
variable is badly names, the model is not a widget.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84306#file84306line34" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">OpenWithConfig::OpenWithConfig( QWidget* parent, QString mimeType )</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">34</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">setButtons</span><span class="p">(</span> <span \
class="n">KDialog</span><span class="o">::</span><span class="n">Cancel</span> <span \
class="o">|</span> <span class="n">KDialog</span><span class="o">::</span><span \
class="n">Apply</span> <span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
be using KDialog::Ok, since the dialog will be closed when clicking it. Apply is for \
situations where the config dialog is kept open but the settings are being \
applied.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84306#file84306line38" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">OpenWithConfig::OpenWithConfig( QWidget* parent, QString mimeType )</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">38</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">connect</span><span class="p">(</span> <span class="k">this</span><span \
class="p">,</span> <span class="n">SIGNAL</span><span class="p">(</span> <span \
class="n">applyClicked</span><span class="p">()</span> <span class="p">),</span> \
<span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span \
class="p">(</span> <span class="n">save</span><span class="p">()</span> <span \
class="p">)</span> <span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
use okClicked and then not use close() in the save() slot.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84306#file84306line83" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">OpenWithConfig::OpenWithConfig( QWidget* parent, QString mimeType )</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">83</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">m_service</span> <span class="o">=</span> <span \
class="n">m_widget</span><span class="o">-&gt;</span><span \
class="n">itemFromIndex</span><span class="p">(</span><span \
class="n">index</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is the \
selection stored in a (not quite well named) variable? You could just query it in \
save(). Also the dialog should not allow to be closed with the checkbox unchecked and \
no item selected IMHO. So the ok button should be disabled accordingly.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84306#file84306line88" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">OpenWithConfig::OpenWithConfig( QWidget* parent, QString mimeType )</pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">88</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">configWidget</span><span class="o">-&gt;</span><span \
class="n">services</span><span class="o">-&gt;</span><span \
class="n">setDisabled</span><span class="p">(</span><span \
class="n">checked</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This could \
be directly connected to the setDisabled slot of the services widget. No need for a \
separate slot here.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84307#file84307line17" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.ui</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">17</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">   &lt;locale \
language=&quot;English&quot; country=&quot;UnitedStates&quot;/&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Where does \
this locale setting come from and what consequences does it have?</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84307#file84307line21" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.ui</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">21</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    \
&lt;layout class=&quot;QVBoxLayout&quot; \
name=&quot;verticalLayout_2&quot;&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This layout \
is unecessary, you&#39;re merely nesting a vertical layout in another which does not \
make any sense.</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/106388/diff/1/?file=84307#file84307line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plugins/openwith/openwithconfig.ui</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        \
&lt;string&gt;Open internal&lt;/string&gt;</pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What does \
this option do? If its about opening the file embedded then why have a checkbox \
instead of listing the embedded editor plugins available. Last I looked at the code \
thats what was happening with the menu too.</pre> </div>
<br />



<p>- Andreas</p>


<br />
<p>On September 9th, 2012, 11:36 a.m., Przemek Czekaj wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Przemek Czekaj.</div>


<p style="color: grey;"><i>Updated Sept. 9, 2012, 11:36 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added a configuration dialog to the context menu.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled, and local install. Tested by hand.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=287764">287764</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plugins/openwith/CMakeLists.txt <span style="color: grey">(8742aeb)</span></li>

 <li>plugins/openwith/openwithconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/openwith/openwithconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/openwith/openwithconfig.ui <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>plugins/openwith/openwithplugin.h <span style="color: \
grey">(809a0e8)</span></li>

 <li>plugins/openwith/openwithplugin.cpp <span style="color: \
grey">(69404ef)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106388/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106388/s/722/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith1_400x100.png" \
style="border: 1px black solid;" alt="OpenWith context menu" /></a>

 <a href="http://git.reviewboard.kde.org/r/106388/s/723/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith2_400x100.png" \
style="border: 1px black solid;" alt="Openwith dialog - internal option" /></a>

 <a href="http://git.reviewboard.kde.org/r/106388/s/724/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/09/kdevplatform-openwith3_400x100.png" \
style="border: 1px black solid;" alt="Open with - selectable list" /></a>

</div>


  </td>
 </tr>
</table>








  </div>
 </body>
</html>



-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic