'Re: Review Request: Fix zip invocation on Windows'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Fix zip invocation on Windows
From:       "Andreas Pakulat" <apaku () gmx ! de>
Date:       2012-08-13 18:37:23
Message-ID: 20120813183723.9565.81915 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105985/#review17334
-----------------------------------------------------------

Ship it!

emerge fetches it from the gnuwin32 project. That its not packaged atm for =
binary packages is probably simply due to no app requiring it, that would c=
hange once kdevelop would be packaged...

So ok from my side until someone comes around with a different zip-tool, th=
en we really need to look into detecting the tool I guess.

- Andreas Pakulat

On Aug. 11, 2012, 9:18 p.m., Steffen Ohrendorf wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105985/
> -----------------------------------------------------------
> =

> (Updated Aug. 11, 2012, 9:18 p.m.)
> =

> =

> Review request for KDevelop.
> =

> =

> Description
> -------
> =

> This fixes the invocation of InfoZIP on Windows which requires the exclus=
ion parameter to be the last one on the command line.
> =

> =

> Diffs
> -----
> =

>   cmake/modules/KDevPlatformMacros.cmake f960e82 =

> =

> Diff: http://git.reviewboard.kde.org/r/105985/diff/
> =

> =

> Testing
> -------
> =

> KDevPlatform successfully zips the app templates.
> =

> =

> Thanks,
> =

> Steffen Ohrendorf
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105985/">http://git.reviewboard.kde.org/r/105985/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">emerge fetches it from \
the gnuwin32 project. That its not packaged atm for binary packages is probably \
simply due to no app requiring it, that would change once kdevelop would be \
packaged...

So ok from my side until someone comes around with a different zip-tool, then we \
really need to look into detecting the tool I guess.</pre>  <br />

<p>- Andreas</p>

<br />
<p>On August 11th, 2012, 9:18 p.m., Steffen Ohrendorf wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By Steffen Ohrendorf.</div>

<p style="color: grey;"><i>Updated Aug. 11, 2012, 9:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This fixes the invocation of InfoZIP on Windows which requires the \
exclusion parameter to be the last one on the command line.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KDevPlatform successfully zips the app templates.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/KDevPlatformMacros.cmake <span style="color: \
grey">(f960e82)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105985/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 