'Re: Review Request: [KDE Provider] Include Modules in the Project List'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: [KDE Provider] Include Modules in the Project List
From:       "Andreas Pakulat" <apaku () gmx ! de>
Date:       2012-07-28 17:24:57
Message-ID: 20120728172457.20240.54220 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105752/#review16580
-----------------------------------------------------------

Ship it!

Ship It!

- Andreas Pakulat

On July 28, 2012, 2:41 p.m., David Narv=C3=A1ez wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105752/
> -----------------------------------------------------------
> =

> (Updated July 28, 2012, 2:41 p.m.)
> =

> =

> Review request for KDevelop.
> =

> =

> Description
> -------
> =

> Include elements named module which also have icons, urls with protocols =
and all. Modules include KDE PIM and KDE Multimedia, among others.
> =

> =

> Diffs
> -----
> =

>   providers/kdeprovider/kdeprojectsmodel.h 25dd739 =

>   providers/kdeprovider/kdeprojectsmodel.cpp 56498da =

>   providers/kdeprovider/kdeprojectsreader.cpp 536c2eb =

> =

> Diff: http://git.reviewboard.kde.org/r/105752/diff/
> =

> =

> Testing
> -------
> =

> 1. Open the KDE Provider
> 2. Filter the project list by PIM
> =

> Before this patch, no PIM module would be loaded. After this patch, all t=
hree PIM modules are available for download.
> =

> =

> Thanks,
> =

> David Narv=C3=A1ez
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105752/">http://git.reviewboard.kde.org/r/105752/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Andreas</p>

<br />
<p>On July 28th, 2012, 2:41 p.m., David Narváez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop.</div>
<div>By David Narváez.</div>

<p style="color: grey;"><i>Updated July 28, 2012, 2:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Include elements named module which also have icons, urls with protocols \
and all. Modules include KDE PIM and KDE Multimedia, among others.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Open the KDE Provider 2. Filter the project list by PIM

Before this patch, no PIM module would be loaded. After this patch, all three PIM \
modules are available for download.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>providers/kdeprovider/kdeprojectsmodel.h <span style="color: \
grey">(25dd739)</span></li>

 <li>providers/kdeprovider/kdeprojectsmodel.cpp <span style="color: \
grey">(56498da)</span></li>

 <li>providers/kdeprovider/kdeprojectsreader.cpp <span style="color: \
grey">(536c2eb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105752/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 