'Re: Review Request: Make area switcher usable when KDevelop runs on an appmenu-enabled system'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kdevelop-devel
Subject:    Re: Review Request: Make area switcher usable when KDevelop runs on an appmenu-enabled system
From:       "Commit Hook" <null () kde ! org>
Date:       2012-05-31 13:20:46
Message-ID: 20120531132046.14664.56321 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105116/#review14299
-----------------------------------------------------------

This review has been submitted with commit c2bb0fa5ccb9459a940af2f02cd444ef=
a2751c10 by Aur=C3=A9lien G=C3=A2teau to branch master.

- Commit Hook

On May 31, 2012, 1:15 p.m., Aur=C3=A9lien G=C3=A2teau wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105116/
> -----------------------------------------------------------
> =

> (Updated May 31, 2012, 1:15 p.m.)
> =

> =

> Review request for KDevelop and Aleix Pol Gonzalez.
> =

> =

> Description
> -------
> =

> When running on an appmenu-enabled system, one cannot add widgets in the =
menubar corner. This patch detects this (by checking QMenuBar::isNativeMenu=
Bar()) and creates an action to hold the area switcher widget in this case.=
 KDevelop itself needs a simple patch to integrate this action in its main =
toolbar (see https://git.reviewboard.kde.org/r/105117/ ).
> =

> =

> Diffs
> -----
> =

>   shell/uicontroller.h a800f00 =

>   shell/uicontroller.cpp 11fdf75 =

>   sublime/mainwindow.h 2656624 =

>   sublime/mainwindow.cpp 3f424f8 =

>   sublime/mainwindow_p.h 12814a0 =

>   sublime/mainwindow_p.cpp 87fb45e =

> =

> Diff: http://git.reviewboard.kde.org/r/105116/diff/
> =

> =

> Testing
> -------
> =

> Tested with and without appmenu running. With appmenu the switcher appear=
s on the left of the main toolbar, without appmenu it appears on the right =
of the menubar, as before.
> =

> =

> Thanks,
> =

> Aur=C3=A9lien G=C3=A2teau
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105116/">http://git.reviewboard.kde.org/r/105116/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit c2bb0fa5ccb9459a940af2f02cd444efa2751c10 by Aurélien Gâteau \
to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On May 31st, 2012, 1:15 p.m., Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated May 31, 2012, 1:15 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When running on an appmenu-enabled system, one cannot add widgets in the \
menubar corner. This patch detects this (by checking QMenuBar::isNativeMenuBar()) and \
creates an action to hold the area switcher widget in this case. KDevelop itself \
needs a simple patch to integrate this action in its main toolbar (see \
https://git.reviewboard.kde.org/r/105117/ ). </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with and without appmenu running. With appmenu the switcher \
appears on the left of the main toolbar, without appmenu it appears on the right of \
the menubar, as before.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shell/uicontroller.h <span style="color: grey">(a800f00)</span></li>

 <li>shell/uicontroller.cpp <span style="color: grey">(11fdf75)</span></li>

 <li>sublime/mainwindow.h <span style="color: grey">(2656624)</span></li>

 <li>sublime/mainwindow.cpp <span style="color: grey">(3f424f8)</span></li>

 <li>sublime/mainwindow_p.h <span style="color: grey">(12814a0)</span></li>

 <li>sublime/mainwindow_p.cpp <span style="color: grey">(87fb45e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105116/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
KDevelop-devel mailing list
KDevelop-devel@kdevelop.org
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel

[prev in list] [next in list] [prev in thread] [next in thread] 